[DirectX] Avoid deprecated PointerUnion methods #122972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PointerUnion's `is`, `get`, and `dyn_cast` have been deprecated in favour of using `isa`, `cast`, and `dyn_cast` directly. Migrate these uses over.
|
@llvm/pr-subscribers-backend-directx Author: Justin Bogner (bogner) ChangesPointerUnion's Full diff: https://github.com/llvm/llvm-project/pull/122972.diff 1 Files Affected:
diff --git a/llvm/lib/Target/DirectX/DXILWriter/DXILBitcodeWriter.cpp b/llvm/lib/Target/DirectX/DXILWriter/DXILBitcodeWriter.cpp
index be68d46a876db2..0e064d7227cea8 100644
--- a/llvm/lib/Target/DirectX/DXILWriter/DXILBitcodeWriter.cpp
+++ b/llvm/lib/Target/DirectX/DXILWriter/DXILBitcodeWriter.cpp
@@ -1390,16 +1390,16 @@ void DXILBitcodeWriter::writeDISubrange(const DISubrange *N,
// TODO: Do we need to handle DIExpression here? What about cases where Count
// isn't specified but UpperBound and such are?
- ConstantInt *Count = N->getCount().dyn_cast<ConstantInt *>();
+ ConstantInt *Count = dyn_cast<ConstantInt *>(N->getCount());
assert(Count && "Count is missing or not ConstantInt");
Record.push_back(Count->getValue().getSExtValue());
// TODO: Similarly, DIExpression is allowed here now
DISubrange::BoundType LowerBound = N->getLowerBound();
- assert((LowerBound.isNull() || LowerBound.is<ConstantInt *>()) &&
+ assert((LowerBound.isNull() || isa<ConstantInt *>(LowerBound)) &&
"Lower bound provided but not ConstantInt");
Record.push_back(
- LowerBound ? rotateSign(LowerBound.get<ConstantInt *>()->getValue()) : 0);
+ LowerBound ? rotateSign(cast<ConstantInt *>(LowerBound)->getValue()) : 0);
Stream.EmitRecord(bitc::METADATA_SUBRANGE, Record, Abbrev);
Record.clear();
|
llvm-beanz
approved these changes
Jan 14, 2025
bogner
changed the title
bob80905
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PointerUnion's
is,get, anddyn_casthave been deprecated in favour of usingisa,cast, anddyn_castdirectly. Migrate these uses over.